Commit graph

605 commits

Author SHA1 Message Date
Kevin Tang
411951c341 make LocSharedLock::mRef ops atomic
The current share() and drop() calls are not thread
safe, which can cause memory heap correuption. This
changes the read / write ops to be atomic.

Change-Id: Ic241d4573bdf2e58c4e264e97bd41b56f882c791
CRs-Fixed: 975372
2016-02-19 12:38:43 -08:00
Dante Russo
41961e47d5 Remove unneeded nmea_cb print
The nmea_cb print can cause excess logging

Change-Id: Ifb9bfe9b3afff224fd3cfe6ec718f3c3cbe45987
CRs-fixed: 974592
2016-02-10 16:34:24 -08:00
Jiafei Wen
625c8c6e4e Add the support for geofence dwell
This change adds the support for
geofence dwell mask.

Change-Id: I4cbde8d3c49ef4ac287d34a88ea25787b507cdbe
CRs-Fixed: 940557
2016-01-22 11:24:20 -08:00
Linux Build Service Account
23bfc84541 Merge "Sub milli sec part in the relevant NMEA Strings" into location.lnx.1.0-dev.1.0 2016-01-14 17:36:30 -08:00
Ruifeng Xu
9b9d777c63 encode field separator characters
Replace all separator characters ('/','+','|','%') in the raw string
by their corresponding encodings (%2F","%2B","%7C", "%25")

Change-Id: I3c895adc2ce1cef36032a25e3c6fd63e70350607
CRs-fixed: 881265
2016-01-14 08:24:09 -08:00
Ruifeng Xu
fbbbb4f391 Xtra client always reports carrier as 'unknown'
The problem was caused by populating the carrier upon phone bootup
when the the property maybe not initialized yet. This module is
updated to remove the populating code of carrier in phone bootup.

Change-Id: I9c3f970aa0f0ca0805fdc2e04aa809329b6a2676
CRs-fixed: 935146
2016-01-14 08:23:20 -08:00
Kevin Tang
1c11832352 Sub milli sec part in the relevant NMEA Strings
NMEA Strings should introduce the sub milli sec part in the
relevant NMEA Strings for NHZ Sessions

Change-Id: I9bac4caa26e87741e5e82e16a8047af20ac8012b
CRs-Fixed: 951144
2016-01-06 14:34:30 -08:00
Jiafei Wen
88c17ef7d7 Add support for dynamic TBF updating
This change adds the support for checking
if modem support dynamic TBF updating.

Change-Id: Ib6bf917f84d1224e296e91b4fb33b41d6e2c2531
CRs-Fixed: 923601
2016-01-04 18:30:07 -08:00
Linux Build Service Account
f7ae18656c Merge "Location: reduce memory footprint" 2015-11-12 09:33:30 -08:00
Valeri Atamaniouk
78bb13288e Location: reduce memory footprint
Reduce memory footprint by moving data sets into const
data segments. Update function parameters to accept const
parameters when appropriate.

CRs-fixed: 928770
Change-Id: I42955cf18de2b0541cfaed89359cdcf9ae6fea8a
2015-11-09 11:33:15 +02:00
Bhavna Sharma
c9a243bc15 Move some debug logs to verbose.
While it is important to continue to log events
at debug level logs, logging all data may not be
as important. Moving such logs to verbose level

CRs-Fixed: 936031

Change-Id: I634d173b645180d55d620a24cce2c31aee966b8f
2015-11-06 20:42:13 -08:00
Linux Build Service Account
15ea4fca38 Merge "set LPP CP as default" 2015-10-16 09:09:27 -07:00
Linux Build Service Account
f0a11ae99a Merge "missing util header file" 2015-10-15 10:51:54 -07:00
Kevin Tang
0b4a33bc45 missing util header file
causing the unit test builds failure.

Change-Id: Id65290c0198904eda020b566e6636b0bb772aa1d
2015-10-09 16:10:40 -07:00
Qiang Chen
56a5a75a22 set LPP CP as default
LPP CPP E911 is required by
many carriers on LTE.

Change-Id: If0d3a3107652e114bfdf7fbb59fe648cb3ddd940
CRs-fixed: 919242
2015-10-09 10:47:42 -07:00
Dante Russo
9336256027 Add support for new sockaddr_storage struct
In order to handle ipv6 requests, a new struct
is being used instead of an array to store ipv6
info

CRs-Fixed: 817295
Change-Id: I030d4206c01724f08b311697f0bbefb1f9fd10e6
2015-10-07 10:25:06 -07:00
Linux Build Service Account
7fc64a6c2f Merge "another potential race condition" 2015-10-03 21:37:27 -07:00
Linux Build Service Account
e8c149a153 Merge "Opt out of clang till issues are fixed" 2015-10-03 09:38:13 -07:00
Kevin Tang
9b3aa46ebb another potential race condition
LocTimer on timeout would currently delete timer delegate.
This meddles into the management of LocTimer::stop() call,
and the order of obj delete needs to be synchronized in a
few different places as a result.

This change lets the delete of the timer delegate obj fold
into the stop() handling, which would be easier to synch.

Change-Id: Ic3e0b3d183dceb9e6e2db4c47ec9d6e296b0c3f6
CRs-Fixed: 916590
2015-09-30 14:03:36 -07:00
Linux Build Service Account
f75c6e0f7b Merge "Fix for Cppcheck warnings" 2015-09-24 21:35:41 -07:00
Linux Build Service Account
9f830f906d Merge "Add 3 new fields in GPS and FLP pipe" 2015-09-24 21:35:40 -07:00
Aravind Asam
68104bd701 Opt out of clang till issues are fixed
Needed for moving to clang

Change-Id: I5922c62cb2f6efc297120c5a359c92a82260f3a7
2015-09-24 16:30:36 -07:00
Linux Build Service Account
bd034a21f2 Merge "Sending FLP fixes to ULP" 2015-09-24 05:12:57 -07:00
Vamana Murthi
e9e399737b Fix for Cppcheck warnings
Fixed cppcheck warnings reported by customer

Change-Id: Ia6cf5e940d204111d8354f9eec71ac816a142719
CRs-fixed: 901373
2015-09-24 13:34:17 +05:30
Jiafei Wen
bf80dfb9e9 Add 3 new fields in GPS and FLP pipe
To support next version of GTP AP protocol,
this change adds the support for the below
3 fields in GPS pipe and FLP pipe :
  1). heading_unc
  2). horizontal_reliability
  3). vertical_reliability

Change-Id: If51c38f9159f372c2b2c12fbb55d123958cfee95
CRs-Fixed: 898876
2015-09-23 18:01:06 -07:00
Linux Build Service Account
30173edcf2 Merge "Crash fix with MsgTask API change" 2015-09-23 01:53:49 -07:00
Jiafei Wen
eb01e397ed Sending FLP fixes to ULP
For crowd sourcing, FLP HAL needs to share
with ULP the flp fixes in real time. This
change is making FLP HAL to send flp fixes
to ULP.

Change-Id: I1a852ec69db8eb50de5c18b03205d1b488cfd4b0
CRs-fixed: 874928 878064
2015-09-22 22:37:57 -07:00
Linux Build Service Account
c40ded235a Merge "Set SUPL_ES to 0 in gps.conf" 2015-09-22 15:33:58 -07:00
Kevin Tang
94ecbf6804 Crash fix with MsgTask API change
Removed tCreate and tAssociate from MsgTask. LocThread
now can optionally take a tCreate method. Associator is
replaced with *firstMsg* option to MsgTask, which is a
more generic option, that can associate or do other set
up job at the create of a MsgTask.

The current MsgTask doesn't use tCreate, which exposes
a slight time window for Location HAL when its MsgTask
is NOT associated to DVM heap but a message delivery to
DVM could be attempted during this time.

Change-Id: Iafd5b91b693baacb9b7064463f8c44f74026f54c
CRs-Fixed: 902350
2015-09-21 14:45:58 -07:00
Linux Build Service Account
049cc84d3a Merge "timer bug fix" 2015-09-19 15:13:48 -07:00
Kevin Tang
088a127c31 timer bug fix
when a ticking timer is stopped, currently kernel doesn't
get updated with the next immediate timer's interval. As a
result, kernel timer will expire sooner (with the stopped
timer's interval), and the next timer's client is notified
for this expiration.

Change-Id: I0d67d1418cb9bfe7f70ae71252901d4c6bb699b3
CRs-Fixed: 909776
2015-09-18 09:30:33 -07:00
Ruifeng Xu
9c22ef8bca fixed XTRA bug
The change included the following fixes:
increased buffer size to hold the initial UA string;
use file for saving the initial UA string

Change-Id: I52ef94e57695f1411a34e338e89325de382b09b5
CRs-fixed: 905170
2015-09-11 13:51:26 -07:00
Linux Build Service Account
c1021a05dc Merge "fixing a crash vulnerability due to race condition" 2015-09-11 07:24:11 -07:00
Kevin Tang
9957a19f5f fixing a crash vulnerability due to race condition
LocTimer::stop() can be called from different threads, which must
be protected. Currently there is a race condition between back to
back stop()'s or expire() + stop() events.

Change-Id: Iae80b78f049a32da87639f813c6f5126b4ccd072
CRs-Fixed: 904627
2015-09-09 10:06:50 -07:00
Kevin Tang
623f5a6fc5 adding dev id into xtra user agent
setting XTRA_USER_AGENT at GPS HAL init time, incorporating
Android sw version, manufacturer, model, board.

CRs-Fixed: 788356

Change-Id: I8d9dcc80a0769796a25a0477f5f1598a292fe8b0
2015-09-02 10:09:14 -07:00
Bhavna Sharma
5e77108972 Fix for timerfd_create on older kernel revisions
BOOTTIME_ALARM and BOOTTIME were added to timerfd_create
in kernel version 3.11 and 3.15 respectively.
But for targets still on older kernel version we fallback on MONOTONIC.

CRs-Fixed: 897805

Change-Id: I47d9780d69ce5ee8c183c84baa93ea3c1a00db57
2015-08-27 10:29:54 -07:00
Linux Build Service Account
f2f492bd5b Merge "Handle race condition in HAL post SSR" 2015-08-25 08:05:05 -07:00
Linux Build Service Account
5501f7e1a2 Merge "memory management fixes" 2015-08-21 08:44:24 -07:00
Linux Build Service Account
082ad3c25d Merge "Move the flp definitions to gps-noship" 2015-08-21 08:44:22 -07:00
Hema Iyer Sankaranarayanan
a50aaae62e Handle race condition in HAL post SSR
Post SSR, ensure necessary config injection is done before restarting
an existing tracking session

Change-Id: I1bec8ff1cab3a9762e73a13958fe91c62f40fb92
CRs-fixed: 888187
2015-08-20 13:18:27 -07:00
Kevin Tang
a38a8b8477 memory management fixes
byte long each, but the loc_set_config_entry() util call
writes an int at a time, causing buffer overflow. #2, in
loc_xtra-init(), a data structure wrap happened without
iniializing the unused data fields.

Change-Id: I96b40a330316927d276840a997082fe759263699
CRs-Fixed: 866937
2015-08-18 17:01:12 -07:00
Jiafei Wen
87b6a3fff4 Move the flp definitions to gps-noship
This change moves those definitions related to FLP form
gps_extented_c.h to gps-noship.

Change-Id: I3da452fa3e885af509199cae9fe1b1f24ff48100
CRs-fixed: 801916
2015-08-18 14:47:47 -07:00
ethan.kim
eb925647d5 Set SUPL_ES to 0 in gps.conf
Disabled checking for emergency to accept SUPL

CRs-fixed: 860504

Change-Id: Iad1605242daf8fa1d6bcce3e69caff7811d9843a
2015-08-18 09:03:18 -07:00
Tushar Janefalkar
cc9f8dc03b Add new event mask for timezone.
Modem sends this event to request for
injection of timezone and offset from
UTC

Change-Id: I664db892bf08f7df9680322405df4c38198cb465
CRs-fixed: 868532
2015-08-17 14:07:29 -07:00
Linux Build Service Account
95fbf27ce1 Merge "NMEA generation change to prevent 2Hz reporting" 2015-08-16 18:07:30 -07:00
Linux Build Service Account
7b819b2b03 Merge "Clear passing up memory for LocApiBase function" 2015-08-13 20:06:26 -07:00
Kevin Tang
898c646a7c crash in LocTimer wrapper
LocTimerWrapper implements loc_timer_start/stop calls for backward
compatibility. There is a race condtiion where the wrapper object
could be deleted by the client thread and expireation handling at
rough the same time, which would have the memory freed twice. Now
they are mutext protected.

Change-Id: I25d7466db88a840a8a09e7a476cface48c91d22e
2015-08-10 10:33:49 -07:00
Linux Build Service Account
277f3e30a3 Merge "LocTimer repeated expiration" 2015-08-09 12:02:14 -07:00
Qiang Chen
923698ad8a Clear passing up memory for LocApiBase function
GpsLocation object need to be cleared in case
the base calss member function being called so
that no bad values will be passed up.

Change-Id: I224ecebb3e4137c1baddd99ce0211a0f60d3e5b4
CRs-fixed: 879356
2015-08-06 18:27:07 -07:00
Kevin Tang
9de97acc86 LocTimer repeated expiration
Timer must be removed from epoll as soon as it expires,
otherwise it continuously expire. Current timer removes
from a different thread, this triggers repeated expire
events until the maintain thread gets to remove it.

Change-Id: Ie523bce5069416521d49bc0178d2cad2dd1f04da
CRs-Fixed: 870568
2015-08-04 15:03:32 -07:00