Commit graph

1177 commits

Author SHA1 Message Date
Yingjie Wang
57a5b186c5 Remove system status reset upon delete aiding data
Delete aiding data command would trigger default gnss engine state set.
Rename setDeafultReport with setDefaultGnssEngineStates and remove system
settings reset in it.

Change-Id: I7b5dffe3191b24e9f5bb6d887705fca34ed94013
CRs-fixed: 2151350
2018-01-03 14:52:33 +08:00
Linux Build Service Account
d519abf0c1 Merge "Replace wall time" 2017-12-25 08:03:44 -08:00
Linux Build Service Account
ce94137dd6 Merge "fixing the location api level race condition on callbacks" 2017-12-21 21:41:01 -08:00
Linux Build Service Account
ce9daaea37 Merge "Fix incorrect cast to avoid integer overflow" 2017-12-21 13:58:26 -08:00
Linux Build Service Account
d75c010c59 Merge "Location Utils - LocIpc class enhancement" 2017-12-21 13:58:24 -08:00
Kevin Tang
03bc75f298 fixing the location api level race condition on callbacks
At the layer right under HIDL impl, where the callback objs
are received from HIDL and used by HAL layer, there is race
condition volnerability which could yield using a incompletely
copied sp obj. Added mutex protection.

Change-Id: I611db590d1fadbe43c74db71a1ea906dbe067c6d
CRs-Fixed: 2144976
2017-12-21 13:29:37 -08:00
Katz Yamada
99e0f11428 Location Utils - LocIpc class enhancement
Add LocIpcSender class and add an overloaded
send method in LocIpc class that takes binary
data block.

Change-Id: I102f23fe8bf378c3bed5cac0086aa9773c62727b
CRs-Fixed: 2144883
2017-12-18 11:37:24 -08:00
Katz Yamada
f3f7a4bf41 Fix incorrect cast to avoid integer overflow
Fix incorrect cast in converting time uncertainty
from integer based source to float.

Change-Id: Ibb75eb1a2d925a7e7ce13275f09a618f241c31bf
CRs-Fixed: 2157401
2017-12-13 12:31:06 -08:00
Kevin Tang
53a1aa5ed5 Fixed incorrect casting for SystemStatus::setNetworkInfo call
An incorrect casting at SystemStatus::eventDataItemNotify was causing a
heap overflow when trying to cast NetworkInfoDataItem into
SystemStatusNetworkInfo, that is bigger.

Change-Id: I3fbd88a1daf210c3c687a6f49ad868968a6efd96
CRs-fixed: 2137958
2017-12-08 18:18:03 -08:00
Baili Feng
edcf000435 Replace wall time
Replace gettimeofday with clock_gettime
CRs-fixed: 2144315

Change-Id: Ie8472d2aedcd0e63b86cc5ff100ce9bb28fd670c
2017-12-05 16:59:41 +08:00
Linux Build Service Account
bac0979ae6 Merge "Record the first connection status notification" 2017-11-28 21:27:59 -08:00
Linux Build Service Account
dceb0d974e Merge "HAL handshake with XTRA" 2017-11-28 17:26:18 -08:00
Bhavna Sharma
e787679074 Record the first connection status notification
Keep record of whether connection status was reported
and report it in the response status

CRs-Fixed: 2126610
Change-Id: I284f53c71f1131a73eed0adaf00b66f04e4100ac
2017-11-28 14:51:43 -08:00
Linux Build Service Account
8fe6a36970 Merge "Check ret value for HIDL callback method" 2017-11-27 04:05:46 -08:00
Linux Build Service Account
68883097b4 Merge "Location Utils - Improve send method of LocIpc" 2017-11-21 00:24:36 -08:00
Yingjie Wang
9fe73f379a Check ret value for HIDL callback method
Judge ret value for niNotifyCb to check HIDL return status

Change-Id: I0cde3716a971941260f2fb12c9e5927bc8c8d548
CRs-fixed: 2147437
2017-11-21 12:20:06 +08:00
Katz Yamada
104f1fee14 Location Utils - Improve send method of LocIpc
Change LocIpc::send() method implementation from
regular member to static, since it does not modify
any of its class member variables. Sender code
should be able to call this method without creating
an instance.

Change-Id: I9d08404c3fae615fd20531904241bf2e246fa592
CRs-Fixed: 2143522
2017-11-16 10:48:11 -08:00
Ruifeng Xu
e21e18a836 HAL handshake with XTRA
send XSSO state on XTRA request; send XTRA the init
event on XSSO start.

Change-Id: Ic1833dc85b7b29259069335bbce26d388ca83d32
CRs-fixed: 2074685
2017-11-15 14:26:31 -08:00
Baili Feng
ccd6716531 Fix $--RMC sentence
Navigational status should be the last element

Change-Id: Ifb201fe95de74e3419e7fe55c55657b41818c64d
CRs-fixed: 2140835
2017-11-09 19:30:14 +08:00
Baili Feng
08cbff337d Adjust NMEA sentence to comply with v4.1
1. Add Navigational status to $--RMC sentence
2. Add Signal ID to $--GSV sentence

Change-Id: I5ae26bed8dcca577ee661a4129858a8482d172a6
CRs-fixed: 2109692
2017-11-07 22:02:11 -08:00
Harikrishnan Hariharan
6ccaa83f60 GetBatchedLocations is unsupported for Live Fix.
Return ERROR_NOT_SUPPORTED from LocationAPIClientBase when
GetBatchedLocations is invoked by a Live fix session id,
which has session mode of SESSION_MODE_ON_FIX.

Change-Id: Ifc57d4d4b16288ed5ac7432da92cf39bfe989416
CRs-Fixed: 2137513
2017-11-03 10:45:41 +05:30
Linux Build Service Account
30b93f6bfc Merge "Enable logcat logging for location modules in LE" 2017-10-28 20:16:36 -07:00
Linux Build Service Account
d72d5b3978 Merge "Invoking HIDL callback via local variable" 2017-10-27 18:14:33 -07:00
Saurabh Srivastava
0107dbe7d3 Invoking HIDL callback via local variable
Copying HIDL callback member variable to
a local variable before invoking.
This is to avoid possible race conditions
with the callback getting updated during
invocation.

Change-Id: Ida9658f4cffafc64754c0cd26541b731cb328155
CRs-Fixed: 2114085
2017-10-27 09:05:29 +08:00
Kevin Tang
63c4d2f67b locAPIRemoveGeofences roolback to async result notification
locAPIRemoveGeofences is rolled back to async result notification,
using the RemoveGeofencesRequest, but using a new temporal bidict
of sessions & ids, to avoid a previous race condition using the
wrong id when removing and adding a geofence.

Change-Id: Icd85373b82e620ea4059431f0c3d13c95f99ca3c
CRs-fixed: 2132679
2017-10-25 15:04:06 -07:00
Saurabh Srivastava
57640c9f33 Checking HIDL callback return value
Change-Id: I937f155b80d54396f86fb44d731bc592ae49411e
CRs-Fixed: 2120892
2017-10-16 19:55:47 +05:30
Harikrishnan Hariharan
5f583c6375 Enable logcat logging for location modules in LE
Add support for logcat logging for location modules
in LE, by adding appropriate flags -llog to LDFLAGS.
Update logging macros to use ALOG* so that logs can
be outputed using standard logcat adb commands.

Change-Id: I94b5a1e9f0b4ec78a55e7189002e0f674ef174d2
CRs-Fixed: 2117669
2017-10-16 14:44:36 +05:30
Linux Build Service Account
9f2a492534 Merge "Fix support for batching without batch full event" 2017-10-13 00:03:56 -07:00
Linux Build Service Account
5a9d01f5f3 Merge "Add battery level observer" 2017-10-13 00:03:54 -07:00
Linux Build Service Account
39419a62e7 Merge "Add storing dataitem in systemstatus report" 2017-10-11 19:55:37 -07:00
Kevin Tang
273e268978 Add battery level observer
added data item id and BatteryLevelDataItemBase type

Change-Id: I7e33b476c787587d0372ec67bd61fa5efe6eef41
CRs-Fixed: 2125054
2017-10-11 12:50:14 -07:00
Linux Build Service Account
4f5eb8623b Merge "Fix crash in AgpsManager when accessing invalid pointer" 2017-10-10 21:26:14 -07:00
Dante Russo
34ce2a6873 Fix support for batching without batch full event
Additional fixes:
-fix issue where if StartTracking or
StartBatching fails at QMI LOC layer, then the
session is stuck and Tracking or Batching cannot
be stoped or started again.
-fix getBatchedLocation API to return an error
if the id given is not valid, as caller
will not get a response callback in this case.

CRs-fixed 2118838
Change-Id: I389fc862836450f0081f6394c971b33614373841
2017-10-10 14:56:34 -07:00
Linux Build Service Account
7b61f5a1b7 Merge "new apis for control xtra throttle" 2017-10-10 10:57:13 -07:00
Bhavna Sharma
de6898af20 Fix crash in AgpsManager when accessing invalid pointer
Crash was happening because a local structure was being
passed over by reference to the MsgTask, as a result
data was being read and saved from the reference when
the local structure was already out of scope.

CRs-Fixed: 2124083

Change-Id: Ifb24652d5b665a47b8ae88f43dd86876274a28cf
2017-10-10 09:22:58 -07:00
Katz Yamada
f5f0f29c13 Add storing dataitem in systemstatus report
SystemStatus stores incoming dataitem events
received from osagent into its internal
systemstatus report cache.

Change-Id: I129c633b45abfc04c9d9bbbd558db5f6e93c1672
CRs-Fixed: 2093347
2017-10-09 10:04:13 -07:00
Harikrishnan Hariharan
e22e04dbe2 Fix compilation errors in xtra-daemon for LE.
Fix compilation errors in xtra-daemon in LE for changes made
as part of adding biway IPC communication changes. New files
created are added as part of LE Makefile.

Change-Id: Ic0f0d60dd85eea38bb47753aea4fccfb3070d64c
CRs-Fixed: 2122852
2017-10-07 15:19:19 +05:30
Ruifeng Xu
35804b9131 new apis for control xtra throttle
added register and unregister apis of a callback
that listens to XTRA client throttle enablement commands.

Change-Id: Id50e7311516593018113203b5dfa700f0fdc037b
CRs-fixed: 2092629
2017-10-05 12:41:27 -07:00
Ruifeng Xu
b0982b4476 add HAL socket
this patch contains the following changes:
1. added header and implemenation files of socket util apis
in libgps.utils; 2. updated XtraSystemStatusObserver to use
the new apis; 3. added HAL socket and new thread to listen to it.

Change-Id: If1f6b4b4d6ea2d03640f68e96f0286300404f42b
CRs-fixed: 2108635
2017-10-05 11:33:37 -07:00
Naresh Munagala
a5c7e2c53d extended gdop parameters in interface files
updated interface files with extended gdop parameters.

Change-Id: Ie31311125e66d26dab4f564be7120fae374b9d2c
CRs-Fixed: 2062856
2017-10-04 22:57:34 -07:00
Bhavna Sharma
39526894cf AGPS Init must complete in one message call
If AGPS initialization is split across multiple
messages on the msgTask, it causes other other
commands to seep in before the initialization can complete.
To avoid this the initialization must be completed in one message.
Also includes some cleanup on AGPS initializations.

CRs-Fixed: 2111399

Change-Id: Id61ceeb12d5781764b42ff9d1868884537ca8d90
2017-09-28 10:11:08 -07:00
Linux Build Service Account
edbc71f1dd Merge "Add support more bp amplitude in systemstatus" 2017-09-27 08:16:37 -07:00
Saurabh Srivastava
7b37deedff KW Warning fixes
Adding fixes for null reference errors.

Change-Id: Ie62bd93860baef2670c164ae7a5d148440308213
CRs-Fixed: 2113171
2017-09-26 03:29:27 -07:00
Linux Build Service Account
6403989a5b Merge "locAPIRemoveGeofences now notify the result inmediately" 2017-09-23 04:40:07 -07:00
Linux Build Service Account
1f8b3587f2 Merge "Set SUPL_HOST to modem on GnssAdapter init." 2017-09-22 18:37:26 -07:00
Kevin Tang
c7642dca5f locAPIRemoveGeofences now notify the result inmediately
locAPIRemoveGeofences is no longer waiting for the request response,
instead it will always notify his callbacks with LOCATION_ERROR_SUCCESS
if the provided id is found, or LOCATION_ERROR_ID_UNKNOWN if not.

Change-Id: I602ad43bee894e85fde1e80210e6477b628e4a39
CRs-fixed: 2099450
2017-09-22 17:28:58 -07:00
Katz Yamada
fe17363801 Add support more bp amplitude in systemstatus
Add support of glo/bds/gal baseband processor
amplitude in systemstatus. These values will
be added in PQWM1 debug NMEA messasge.

Change-Id: If880bdfa81b41a82bb133bda8a0b33862f3eade5
CRs-Fixed: 2091024
2017-09-22 13:08:59 -07:00
Saurabh Srivastava
220b5cb581 Adding fix to send SUPL_ES ATL Close complete
Sending ATL Close complete for both Unsubscribe
and Released event.

CRs-Fixed: 2113762
Change-Id: Id684a05aa6d2b8636efb8af3d967146bd1718994
2017-09-21 21:11:37 -07:00
Kevin Tang
fb4bbe52f4 fixing conn disconnect handling from GnssLocationProvider
The "type" needs to maintain as signed, in case some value
may come across as negative, even though the storage size
may vary, from 8-bit to 32-bit, for example.

Bug: 65164961

Change-Id: Ieb3fb4b6f8415444bbe192a7875093f86a9c3068
CRs-Fixed: 2106350
2017-09-20 17:47:48 -07:00
Harikrishnan Hariharan
0ebaba253f Set SUPL_HOST to modem on GnssAdapter init.
On init of GnssAdapter, SUPL_HOST and SUPL_PORT are set to
modem if the configs are set in gps.conf.

Change-Id: I079879adf31022cfbf0098da8dba3bb86feed069
CRs-Fixed: 2110547
2017-09-20 00:31:51 -07:00