Commit graph

16 commits

Author SHA1 Message Date
Kevin Tang
61de97e130 LE clean up
separated utils, core, ds and loc-api-v02 from loc-hal into their
own independent packages; simplified loc-pla; moved pla to the
root of project; removed loc-stub.

Change-Id: I373f02f9306646addf55ae90d71c4ba8e3741d09
CRs-Fixed: 2172544
2018-01-16 13:35:38 -08:00
Yingjie Wang
86ad4f8f44 Enable LOGV for gps directory
Define LOG_NDEBUG 0 to enable VERBOSE log messages in
hardware/qcom/gps

Change-Id: I954cad757f13d6bac99b7a06625daa0ace84a17e
CRs-fixed: 2025673
2017-04-28 18:24:07 +08:00
Linux Build Service Account
a7423ca85d Merge "possible NULL pointer dereference" 2017-03-21 19:20:47 -07:00
Kevin Tang
5253a74c6b possible NULL pointer dereference
it appears some of the MsgTask msgs might fail
to create, ending up with a NULL pointer, in
which case when it gets received, dereferencing
a NULL pointer will happen, causing crash.

Change-Id: I5a4295b4fba9c8383754e2abe6558782b1b83143
CRs-Fixed: 1106034
2017-03-15 19:23:41 -07:00
Kevin Tang
3fb8076a5e fixing a race condition on MsgTask::destroy()
when MsgTask::destroy() happens, msg_q_unblock() triggers
the running thread to come out from blocking state. A race
condition may happen such that that thread may complete
first, causing msgTask obj to be already deleted. A next
allocation may change the value at MsgTask::mThread. Then
when control comes back to destroy(), it may try to check
mThread and call delete on it to crash the program.

mThread is a heap obj, so it is possible to delete it after
the hosting msgTask obj is deleted.  We just have to keep
its value on the stack before calling msg_q_unblock().

Change-Id: If15884815eea05fbfa523ec92aa300ed21ef897c
CR-Fixed: 1091530
2017-03-15 18:33:17 -07:00
Dante Russo
c85c8ff673 LocationAPI implementation
Implementation of LocationAPI into gps hal
to be a common API that is called into by platform
specific APIs.

Change-Id: Ie5a7bd217d4ae2175ad49e6aca2fb6ecd4702f3b
CRs-fixed: 1112712
2017-02-28 16:47:50 -08:00
Deven Patel
285d395703 Revert "Revert "Fix compilation issues for m_master merge into oe_master"."
This reverts commit fa7a874eb0

Change-Id: Id2415d80fa3cbdc124e0a3bdd2722db7f233ad53
2016-03-15 12:20:25 -07:00
Deven Patel
a376de4826 Revert "Revert "Merging m_master changes to oe_master"."
This reverts commit a29688ff34

Change-Id: Iab525a58ddb6a00e119afe19f4f51b07b7f428f2
2016-03-15 12:20:01 -07:00
Deven Patel
a29688ff34 Revert "Merging m_master changes to oe_master".
This reverts commit 1aeb6bad84

Change-Id: Iec0a96e7cdfe55ef5836c92a2ae1cce407f6cd5e
2016-03-07 10:55:20 -08:00
Deven Patel
fa7a874eb0 Revert "Fix compilation issues for m_master merge into oe_master".
This reverts commit ecb67363ee

Change-Id: I7b540247b246ea4caf710247d2c58b55515dae7c
2016-03-07 10:52:46 -08:00
Kevin Tang
ecb67363ee Fix compilation issues for m_master merge into oe_master
Fixed compilation issues for M upgrade

Change-Id: I602aa7c8a2db9682a1fe94b7ca892027281deec7
2016-02-04 10:06:28 -08:00
Kevin Tang
1aeb6bad84 Merging m_master changes to oe_master
Merging LA m_master changes to oe_master

merge head - 89f41a9b16

Change-Id: I9010487f1d6f3d2e30a568b441bc5f9b719a0fb1
2016-02-04 10:03:40 -08:00
Bhavna Sharma
c9a243bc15 Move some debug logs to verbose.
While it is important to continue to log events
at debug level logs, logging all data may not be
as important. Moving such logs to verbose level

CRs-Fixed: 936031

Change-Id: I634d173b645180d55d620a24cce2c31aee966b8f
2015-11-06 20:42:13 -08:00
Kevin Tang
94ecbf6804 Crash fix with MsgTask API change
Removed tCreate and tAssociate from MsgTask. LocThread
now can optionally take a tCreate method. Associator is
replaced with *firstMsg* option to MsgTask, which is a
more generic option, that can associate or do other set
up job at the create of a MsgTask.

The current MsgTask doesn't use tCreate, which exposes
a slight time window for Location HAL when its MsgTask
is NOT associated to DVM heap but a message delivery to
DVM could be attempted during this time.

Change-Id: Iafd5b91b693baacb9b7064463f8c44f74026f54c
CRs-Fixed: 902350
2015-09-21 14:45:58 -07:00
Neethu Joseph
50ae85852a MsgTask thread must call associator function always
All instances of MsgTask were not calling associator
because of a use of a static variable check.
All instance of MsgTask thread must call the associator.

CRs-Fixed: 870450

Change-Id: I18314ec3ca0fe21f4bbd12a505bf552e64e25307
2015-08-04 14:59:48 -07:00
Kevin Tang
bb5d2d4bfb Adding a number of utilities
LocHeap, LocThread, LocTimer, and moved MsgTask to
utils. Also added are LocRankable and LocRunnable
abstract classes.

Change-Id: I76975455d24f2c84a95dcc1b04f79fea562ea5ba
CRs-Fixed: 855222
2015-08-04 14:29:48 -07:00
Renamed from core/MsgTask.cpp (Browse further)