From 9e44ec3ce2e897c13012d6415297bdfdcfc5a10e Mon Sep 17 00:00:00 2001
From: Naresh Munagala <nareshm@codeaurora.org>
Date: Tue, 3 Jan 2017 22:21:57 +0530
Subject: [PATCH] force undefined symbols to treat as errors

added necessary flags in Makefiles to
treat undefined symbols to get caught at
compile time.

Change-Id: I77068b0d61ad432aa227c01b6229d82651ab8862
---
 core/Makefile.am                                         | 4 ++--
 utils/Makefile.am                                        | 4 ++--
 utils/platform_lib_abstractions/loc_pla/src/Makefile.am  | 4 ++--
 utils/platform_lib_abstractions/loc_stub/src/Makefile.am | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/core/Makefile.am b/core/Makefile.am
index b3d833f6..0a9d3e2a 100644
--- a/core/Makefile.am
+++ b/core/Makefile.am
@@ -33,11 +33,11 @@ libloc_core_la_SOURCES = $(libloc_core_la_c_sources)
 
 if USE_GLIB
 libloc_core_la_CFLAGS = -DUSE_GLIB $(AM_CFLAGS) @GLIB_CFLAGS@
-libloc_core_la_LDFLAGS = -lstdc++ -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
+libloc_core_la_LDFLAGS = -lstdc++ -Wl,-z,defs -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
 libloc_core_la_CPPFLAGS = -DUSE_GLIB $(AM_CFLAGS) $(AM_CPPFLAGS) @GLIB_CFLAGS@
 else
 libloc_core_la_CFLAGS = $(AM_CFLAGS)
-libloc_core_la_LDFLAGS = -lpthread -shared -version-info 1:0:0
+libloc_core_la_LDFLAGS = -Wl,-z,defs -lpthread -shared -version-info 1:0:0
 libloc_core_la_CPPFLAGS = $(AM_CFLAGS) $(AM_CPPFLAGS)
 endif
 
diff --git a/utils/Makefile.am b/utils/Makefile.am
index f816565b..b121dc85 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -41,11 +41,11 @@ libgps_utils_so_la_SOURCES = $(libgps_utils_so_la_c_sources)
 
 if USE_GLIB
 libgps_utils_so_la_CFLAGS = -DUSE_GLIB $(AM_CFLAGS) @GLIB_CFLAGS@
-libgps_utils_so_la_LDFLAGS = -lstdc++ -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
+libgps_utils_so_la_LDFLAGS = -lstdc++ -Wl,-z,defs -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
 libgps_utils_so_la_CPPFLAGS = -DUSE_GLIB $(AM_CFLAGS) $(AM_CPPFLAGS) @GLIB_CFLAGS@
 else
 libgps_utils_so_la_CFLAGS = $(AM_CFLAGS)
-libgps_utils_so_la_LDFLAGS = -lpthread -shared -version-info 1:0:0
+libgps_utils_so_la_LDFLAGS = -Wl,-z,defs -lpthread -shared -version-info 1:0:0
 libgps_utils_so_la_CPPFLAGS = $(AM_CFLAGS) $(AM_CPPFLAGS)
 endif
 
diff --git a/utils/platform_lib_abstractions/loc_pla/src/Makefile.am b/utils/platform_lib_abstractions/loc_pla/src/Makefile.am
index 6ee0be70..d82aa55b 100644
--- a/utils/platform_lib_abstractions/loc_pla/src/Makefile.am
+++ b/utils/platform_lib_abstractions/loc_pla/src/Makefile.am
@@ -27,11 +27,11 @@ libloc_pla_la_SOURCES = \
 
 if USE_GLIB
 libloc_pla_la_CFLAGS = -DUSE_GLIB $(AM_CFLAGS) @GLIB_CFLAGS@
-libloc_pla_la_LDFLAGS = -lstdc++ -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
+libloc_pla_la_LDFLAGS = -lstdc++ -Wl,-z,defs -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
 libloc_pla_la_CPPFLAGS = -DUSE_GLIB $(AM_CFLAGS) $(AM_CPPFLAGS) @GLIB_CFLAGS@
 else
 libloc_pla_la_CFLAGS = $(AM_CFLAGS)
-libloc_pla_la_LDFLAGS = -lpthread -shared -version-info 1:0:0
+libloc_pla_la_LDFLAGS = -Wl,-z,defs -lpthread -shared -version-info 1:0:0
 libloc_pla_la_CPPFLAGS = $(AM_CFLAGS) $(AM_CPPFLAGS)
 endif
 
diff --git a/utils/platform_lib_abstractions/loc_stub/src/Makefile.am b/utils/platform_lib_abstractions/loc_stub/src/Makefile.am
index 8bda7113..ba823a24 100644
--- a/utils/platform_lib_abstractions/loc_stub/src/Makefile.am
+++ b/utils/platform_lib_abstractions/loc_stub/src/Makefile.am
@@ -26,11 +26,11 @@ library_includedir = $(pkgincludedir)
 
 if USE_GLIB
 libloc_stub_la_CFLAGS = -DUSE_GLIB $(AM_CFLAGS) @GLIB_CFLAGS@
-libloc_stub_la_LDFLAGS = -lstdc++ -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
+libloc_stub_la_LDFLAGS = -lstdc++ -Wl,-z,defs -lpthread @GLIB_LIBS@ -shared -version-info 1:0:0
 libloc_stub_la_CPPFLAGS = -DUSE_GLIB $(AM_CFLAGS) $(AM_CPPFLAGS) @GLIB_CFLAGS@
 else
 libloc_stub_la_CFLAGS = $(AM_CFLAGS)
-libloc_stub_la_LDFLAGS = -lpthread -shared -version-info 1:0:0
+libloc_stub_la_LDFLAGS = -Wl,-z,defs -lpthread -shared -version-info 1:0:0
 libloc_stub_la_CPPFLAGS = $(AM_CFLAGS) $(AM_CPPFLAGS)
 endif